Skip to content

merging master into experiimental - #351

Open
dellams wants to merge 1118 commits into
Experimentalfrom
master
Open

merging master into experiimental#351
dellams wants to merge 1118 commits into
Experimentalfrom
master

Conversation

@dellams

@dellams dellams commented Dec 22, 2025

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Moderate risk because it changes CI orchestration by adding a new test-starapi-client job and making release builds depend on it; failures or environment assumptions in the PowerShell test suite could block packaging. Other changes are documentation and .gitignore hygiene with minimal runtime impact.

Overview
CI now runs the STARAPIClient automated suite by adding a new test-starapi-client job that executes OASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1, uploads TestResults/ artifacts, and is required for build-and-package.

Repo hygiene and docs were expanded: .gitignore now excludes common deployment secrets/config (e.g. .env, hardhat.config.js, deployed-addresses.json, *.key/*.pem) and STAR CLI publish/install artifacts; a stale Dockerfile.star-api.new was removed; and multiple new Docs/Devs/* guides were added/linked covering smart-contract deployment and cross-platform getting-started/installer workflows.

Written by Cursor Bugbot for commit d69b90f. This will update automatically on new commits. Configure here.

Comment thread ONODE/NextGenSoftware.OASIS.API.ONODE.Core/Managers/COSMICManager.cs Outdated
Comment thread OASIS Architecture/NextGenSoftware.OASIS.OASISBootLoader/OASISBootLoader.cs Outdated
Comment thread ONODE/NextGenSoftware.OASIS.API.ONODE.Core/Enums/InteropProviderType.cs Outdated
Comment thread OASIS Architecture/NextGenSoftware.OASIS.API.Core/Helpers/MetaDataHelper.cs Outdated
Comment thread OASIS Architecture/NextGenSoftware.OASIS.OASISBootLoader/OASISBootLoader.cs Outdated
Comment thread OASIS Architecture/NextGenSoftware.OASIS.API.Core/Helpers/MetaDataHelper.cs Outdated
Comment thread OASIS Architecture/NextGenSoftware.OASIS.API.Core/Holons/Web4NFTCollectionBase.cs Outdated
Comment thread OASIS Architecture/NextGenSoftware.OASIS.API.Core/Enums/HolonType.cs Outdated
Comment thread .gitignore Outdated
Comment thread OASIS Architecture/NextGenSoftware.OASIS.API.Core/Enums/HolonType.cs Outdated
Comment thread .gitignore
Comment thread .github/workflows/ci-cd.yml Outdated
Comment thread .gitignore
Comment thread .gitignore
Comment thread Docs/Devs/CONTRACT_DEPLOYMENT.md Outdated
npx hardhat run scripts/deploy.js --network optimism
# ... etc for each chain
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation references non-existent script directory paths

High Severity

The deployment documentation instructs users to run commands like node scripts/deploy-evm-chain.js and cp scripts/hardhat.config.template.js hardhat.config.js, but these scripts are actually located at Scripts/Smart Contracts/, not scripts/. Every command users run following the documentation will fail with "file not found" errors. The deployment scripts exist but at the wrong path documented.

Additional Locations (2)

Fix in Cursor Fix in Web

npm run deploy:all:testnet
npm run deploy:aptos:testnet
npm run deploy:sui:mainnet
# ... see package.json for all scripts

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing npm scripts referenced in documentation

High Severity

The documentation claims users can run npm scripts like npm run check-status, npm run deploy:ethereum:testnet, and npm run deploy:all:testnet, but the root package.json contains no scripts section at all—only a devDependency for mermaid-cli. Users attempting to run these documented commands will get "missing script" errors.

Additional Locations (1)

Fix in Cursor Fix in Web

3. **Checklist**: `DEPLOYMENT_CHECKLIST.md` - Step-by-step checklist
4. **Status**: `DEPLOYMENT_STATUS.md` - Current deployment status
5. **Scripts**: `scripts/README.md` - Scripts documentation
6. **Summary**: `scripts/DEPLOYMENT_AUTOMATION_SUMMARY.md` - Automation overview

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation index references non-existent files

Medium Severity

The documentation index references scripts/QUICK_START.md and scripts/README.md as available documentation files, but these files don't exist at the specified paths. Users looking for the Quick Start guide or Scripts documentation will encounter broken references.

Additional Locations (1)

Fix in Cursor Fix in Web

shell: pwsh
run: |
& "OASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1" -Configuration Release -KillStaleTestHosts $true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STARAPIClient tests likely fail on Ubuntu

High Severity

The new test-starapi-client job runs run_star_api_test_suite.ps1 on ubuntu-latest via pwsh, but related STARAPIClient scripts in the same area use Windows-only tooling/paths (e.g., C:\..., MSVC). If run_star_api_test_suite.ps1 has similar assumptions, the workflow will fail and block build-and-package via needs.

Additional Locations (1)

Fix in Cursor Fix in Web

Comment thread .gitignore
STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/Default/OASIS_DNA.json
STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/CelestialBodyDNA.json
STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/Cosmos.CRTCompat.dll
STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/installers/star-cli-3.4.0-win-x64.exe

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entire publish gitignore block duplicated from merge

Low Severity

The entire block of publish directory entries (lines 315–877) is exactly duplicated at lines 878–1440, adding ~560 redundant lines from what appears to be a merge artifact. Additionally, most entries under publish/ subdirectories are already covered by the existing publish/ pattern on line 139, making them doubly unnecessary. Only the publishwin-x64/ entries aren't covered by the existing pattern.

Additional Locations (1)

Fix in Cursor Fix in Web

@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 26, 2026 05:10 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 06:43 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 08:12 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 19:04 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 19:11 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 20:29 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 20:31 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 20:31 Inactive
@railway-app
railway-app Bot temporarily deployed to invigorating-recreation / production February 27, 2026 21:04 Inactive
dellams added 30 commits August 21, 2026 02:50
…graph

- Pure GraphQL over https://api.lens.xyz/graphql (no external NuGet deps)
- LoadAvatarByUsernameAsync: profile by Lens handle (lens/stani)
- LoadAvatarByProviderKeyAsync: default profile by owner EVM address
- LoadAllAvatarsAsync: top Lens profiles by followers via exploreProfiles
- LoadHolonAsync(providerKey): load publication by Lens publication ID
- LoadAllHolonsAsync: explore trending posts via explorePublications
- LoadHolonsForParentAsync(profileId): all posts for a given profile
- SearchAsync: search profiles by keyword via searchProfiles query
- CreatePostAsync: post creation with onchain mutation (requires JWT access token)
- SaveAvatar/SaveHolon/Delete: return informative error (EVM wallet signature required)
- LensOASIS added to ProviderType enum in API.Core submodule
- Project added to The OASIS Minimal.sln
…n, swagger, and docs

- UrbitOASIS.cs: full HTTP airlock implementation (contact-store avatars, graph-store holons)
- Add UrbitOASIS.csproj with conditional ProjectReference/PackageReference
- Add UrbitOASIS and LensOASIS to The OASIS Minimal.sln with config entries
- Swagger Startup.cs: add LensOASIS and UrbitOASIS to provider list
- Docs/Provider-Roadmap.md: add LensOASIS row; mark Farcaster/Nostr/Lens/Urbit as Done
- Remove stale generation comments from 7 provider files (all methods fully implemented)
…OASIS providers

- StellarOASIS: Horizon REST API, Ed25519 signing (.NET 10 native), XDR transaction building
  Avatars=Stellar accounts, Holons=transactions; reads public, writes need secret key
- AzureStorageOASIS: Azure.Storage.Blobs — JSON blobs in oasis-avatars/oasis-holons containers
  Full CRUD with blob tags for indexed lookup (Username, Email, HolonType)
- SQLServerDBOASIS: Microsoft.Data.SqlClient ADO.NET, MERGE upserts, JSON_VALUE search
  Tables: OASISAvatars, OASISAvatarDetails, OASISHolons with indexed lookup columns
- OracleDBOASIS: Oracle.ManagedDataAccess.Core ADO.NET, CLOB for JSON, Oracle MERGE
  Tables: OASIS_AVATARS, OASIS_AVATAR_DETAILS, OASIS_HOLONS (RAW(16) GUIDs, ROWNUM paging)
- All four added to The OASIS Minimal.sln with Debug/Release config entries
- Swagger Startup.cs and Docs/Provider-Roadmap.md updated with all four providers
…STAR ODK, WEB6 etc were not being checked out
…uded by .dockerignore so submodule init was impossible
Maps Loom workspace users to OASIS Avatars and Loom videos to OASIS
Holons. Full CRUD: videos load/save/delete via Loom REST API v1.
SaveHolonAsync uses the two-step create-then-upload flow — presigned
upload URL returned in MetaData[LoomUploadUrl]. Paginated LoadAll
and LoadHolonsForParent (folder-based hierarchy). Search across
video titles and workspace member names/emails. Updates solution,
swagger description, and provider roadmap.
…, Ceramic, Basechain

Full real implementations, no stubs or TODOs:

BlueSkyOASIS  — AT Protocol / Bluesky; XRPC REST API; DID/AT-URI as keys;
                posts as Holons, profiles as Avatars; app passwords auth.

MatrixOASIS   — Matrix Client-Server API v3; any homeserver via MATRIX_HOMESERVER;
                room events as Holons, @user:server DIDs as Avatars; access-token auth.

FilecoinOASIS — Lotus JSON-RPC via Glif.io public endpoint; storage deals/CIDs as Holons;
                Filecoin addresses as Avatars; ClientImport + ClientStartDeal for saves.

AlgorandOASIS — Algod v2 REST + Indexer via Algonode.io (no API key needed);
                transactions as Holons (with ASA support), accounts as Avatars;
                note-prefix indexer search; signed-tx broadcast for saves.

CeramicOASIS  — Ceramic HTTP API; TileDocument streams as Holons;
                DID document resolution for Avatars; ComposeDB-compatible;
                pinned-stream enumeration and unpin for soft-delete.

BasechainOASIS — Loom Network Basechain EVM sidechain via standard eth JSON-RPC;
                 transactions as Holons, EVM accounts as Avatars;
                 block-scan history for LoadHolonsForParent; raw-tx broadcast for saves.

Also: all 6 projects added to The OASIS Minimal.sln.
BlueSkyOASIS, MatrixOASIS, FilecoinOASIS, AlgorandOASIS, CeramicOASIS,
BasechainOASIS and LoomOASIS added to:
- The OASIS.sln
- The OASIS - NoTests.sln
- The OASIS - Public.sln
- The OASIS - NoTests - Public.sln

(The OASIS Core Only.sln has no provider projects — unchanged.)
- Startup.cs: add <li> swagger descriptions for BlueSkyOASIS, MatrixOASIS,
  FilecoinOASIS, AlgorandOASIS, CeramicOASIS, BasechainOASIS
- Provider-Roadmap.md: mark all 6 as Done in inventory and summary table;
  promote Discord and The Graph to Next priority; update date to 2026-08-22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant